> On March 17, 2016, 11:37 a.m., Jie Yu wrote: > > src/CMakeLists.txt, line 279 > > <https://reviews.apache.org/r/44549/diff/4/?file=1300631#file1300631line279> > > > > I don't think we put headers here.
I had the same concern before, because it seems most source files here are .cpp. But I also see the followings, so I guess it should be OK to put headers here as well? `slave/containerizer/composing.cpp` `slave/containerizer/composing.hpp` `slave/containerizer/docker.cpp` `slave/containerizer/docker.hpp` - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123972 ----------------------------------------------------------- On March 16, 2016, 10:09 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44549/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 10:09 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Introduced a protobuf message "NetworkConfig". > > > Diffs > ----- > > src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 > src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/spec.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/spec.proto PRE-CREATION > > Diff: https://reviews.apache.org/r/44549/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
