> On June 13, 2016, 11:40 a.m., Klaus Ma wrote: > > src/common/values.cpp, lines 411-419 > > <https://reviews.apache.org/r/48593/diff/2/?file=1415977#file1415977line411> > > > > Any data on performance improvement? > > Yanyan Hu wrote: > Hi, Klaus, performance data is listed here: > https://issues.apache.org/jira/browse/MESOS-5425# thanks.
Thanks; according to the data. It seems worse performance when # < 200, but better performance when # > 200. I'm not sure which is general case in production :). - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review137223 ----------------------------------------------------------- On June 12, 2016, 4:03 p.m., Yanyan Hu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48593/ > ----------------------------------------------------------- > > (Updated June 12, 2016, 4:03 p.m.) > > > Review request for mesos and Guangya Liu. > > > Bugs: MESOS-5425 > https://issues.apache.org/jira/browse/MESOS-5425 > > > Repository: mesos > > > Description > ------- > > This patch reimplement Ranges subtraction using > IntervalSet data type: Ranges values will be > converted to IntervalSet values for subtraction > and the result will be converted back to Ranges > after subtraction is done. This change is for > fixing jira MESOS-5425. > > > Diffs > ----- > > src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b > > Diff: https://reviews.apache.org/r/48593/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yanyan Hu > >
