----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review140147 -----------------------------------------------------------
Patch looks great! Reviews applied: [49223] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 30, 2016, 5:12 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49223/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 5:12 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5739 > https://issues.apache.org/jira/browse/MESOS-5739 > > > Repository: mesos > > > Description > ------- > > Enhance value parsing. > > 1. Did not support [1-2, [3-4]] as Ranges; it should be [1-2, 3-4]. > 2. Did not support {a{b, c}d} as Set; it should be {ab, cd} > 3. Add TODO for checking Text against [a-zA-Z0-9_/.-] > > > Diffs > ----- > > src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b > src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 > > Diff: https://reviews.apache.org/r/49223/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Klaus Ma > >