----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review140294 -----------------------------------------------------------
src/common/values.cpp (line 604) <https://reviews.apache.org/r/49223/#comment205669> donot update here src/common/values.cpp (line 620) <https://reviews.apache.org/r/49223/#comment205670> I think here should be udpated to return Error("Expecting one or more 'ranges'"); Using '' is good enough. src/common/values.cpp (lines 648 - 649) <https://reviews.apache.org/r/49223/#comment205671> I think the `[Mesos Attributes & Resources](attributes-resources.md)` will not work as a hyperlink here. s/Text/text // TODO(klaus1982): Check text against document attributes-resources.md. src/common/values.cpp (lines 666 - 667) <https://reviews.apache.org/r/49223/#comment205672> ditto src/tests/values_tests.cpp (line 204) <https://reviews.apache.org/r/49223/#comment205673> Would it make sense to add some negative case here to test against the code for error handling? - Guangya Liu On 六月 30, 2016, 5:12 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49223/ > ----------------------------------------------------------- > > (Updated 六月 30, 2016, 5:12 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5739 > https://issues.apache.org/jira/browse/MESOS-5739 > > > Repository: mesos > > > Description > ------- > > Enhance value parsing. > > 1. Did not support [1-2, [3-4]] as Ranges; it should be [1-2, 3-4]. > 2. Did not support {a{b, c}d} as Set; it should be {ab, cd} > 3. Add TODO for checking Text against [a-zA-Z0-9_/.-] > > > Diffs > ----- > > src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b > src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 > > Diff: https://reviews.apache.org/r/49223/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Klaus Ma > >
