> On July 1, 2016, 1:27 p.m., Guangya Liu wrote: > > src/tests/values_tests.cpp, line 204 > > <https://reviews.apache.org/r/49223/diff/3/?file=1433898#file1433898line204> > > > > Would it make sense to add some negative case here to test against the > > code for error handling?
Will handle in https://issues.apache.org/jira/browse/MESOS-5603 . - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review140294 ----------------------------------------------------------- On July 4, 2016, 6:33 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49223/ > ----------------------------------------------------------- > > (Updated July 4, 2016, 6:33 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5739 > https://issues.apache.org/jira/browse/MESOS-5739 > > > Repository: mesos > > > Description > ------- > > Enhance value parsing. > > > Diffs > ----- > > src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b > src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 > > Diff: https://reviews.apache.org/r/49223/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Klaus Ma > >
