> On 七月 4, 2016, 11:55 a.m., Guangya Liu wrote: > > src/common/values.cpp, line 673 > > <https://reviews.apache.org/r/49223/diff/4/?file=1436140#file1436140line673> > > > > Sorry, I should ask this question in previous patch. Same as above, can > > you please show more comments for what do you want to check here? It would > > be great if you can make the comment easy to understand. > > Klaus Ma wrote: > Only [0-9a-z./] is available for Text in document. > > Guangya Liu wrote: > OK, then what about "Check `text resource` in the format of > `[a-zA-Z0-9_/.-]`.", ditto for above. > > Klaus Ma wrote: > 1, Text is not resource; 2. I'd like to depdent on document; otherwise, > we need to align TODO and doc.
People will be confused by the `text` here and L664 & L666, what about "Check `text value` against document attributes-resources.md." - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review140648 ----------------------------------------------------------- On 七月 4, 2016, 10:33 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49223/ > ----------------------------------------------------------- > > (Updated 七月 4, 2016, 10:33 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5739 > https://issues.apache.org/jira/browse/MESOS-5739 > > > Repository: mesos > > > Description > ------- > > Enhance value parsing. > > > Diffs > ----- > > src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b > src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 > > Diff: https://reviews.apache.org/r/49223/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Klaus Ma > >
