----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/#review156423 -----------------------------------------------------------
Nice first patch and welcome to the community! - Can you update the Testing Done section with details on testing? - We also support Python bindings. Do you mind adding these protos to our python build too in a follow up review? (See my comments later on how you can use review dependencies if you are new to ReviewBoard) include/mesos/v1/allocator/allocator.proto (lines 21 - 22) <https://reviews.apache.org/r/53825/#comment226628> These changes seem unrelated to this change i.e., java protos generation. We prefer single logical atomic commits in Mesos. For more info see: http://mesos.apache.org/documentation/latest/submitting-a-patch/ Can you create a separate patch for this and make this review dependent on it? The `post-reviews.py` script would do it automatically for you. src/Makefile.am (lines 337 - 341) <https://reviews.apache.org/r/53825/#comment226627> Nit: Sort them alphabetically. src/Makefile.am (lines 1630 - 1634) <https://reviews.apache.org/r/53825/#comment226629> Nit: Sort them alphabetically. - Anand Mazumdar On Nov. 18, 2016, 8:04 a.m., Vijay Srinivasaraghavan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53825/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 8:04 a.m.) > > > Review request for mesos, Anand Mazumdar and Zameer Manji. > > > Bugs: MESOS-6597 > https://issues.apache.org/jira/browse/MESOS-6597 > > > Repository: mesos > > > Description > ------- > > MESOS-6597 Enabled java protos generation for all V1 proto files. > > > Diffs > ----- > > include/mesos/v1/allocator/allocator.proto > 73d45b37a7afc47366a4a01a36912f30b47c30b1 > src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac > > Diff: https://reviews.apache.org/r/53825/diff/ > > > Testing > ------- > > > Thanks, > > Vijay Srinivasaraghavan > >
