> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote: > > include/mesos/v1/allocator/allocator.proto, lines 21-22 > > <https://reviews.apache.org/r/53825/diff/2/?file=1566692#file1566692line21> > > > > These changes seem unrelated to this change i.e., java protos > > generation. We prefer single logical atomic commits in Mesos. For more info > > see: http://mesos.apache.org/documentation/latest/submitting-a-patch/ > > > > Can you create a separate patch for this and make this review dependent > > on it? The `post-reviews.py` script would do it automatically for you.
Actually, this fix is also part of the same issue. The proto file was missing specific java package definition and hence the java file gets generated in a package location different from the other java files. - Vijay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/#review156423 ----------------------------------------------------------- On Nov. 18, 2016, 8:04 a.m., Vijay Srinivasaraghavan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53825/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 8:04 a.m.) > > > Review request for mesos, Anand Mazumdar and Zameer Manji. > > > Bugs: MESOS-6597 > https://issues.apache.org/jira/browse/MESOS-6597 > > > Repository: mesos > > > Description > ------- > > MESOS-6597 Enabled java protos generation for all V1 proto files. > > > Diffs > ----- > > include/mesos/v1/allocator/allocator.proto > 73d45b37a7afc47366a4a01a36912f30b47c30b1 > src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac > > Diff: https://reviews.apache.org/r/53825/diff/ > > > Testing > ------- > > > Thanks, > > Vijay Srinivasaraghavan > >
