> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote: > > Nice first patch and welcome to the community! > > > > - Can you update the Testing Done section with details on testing? > > - We also support Python bindings. Do you mind adding these protos to our > > python build too in a follow up review? (See my comments later on how you > > can use review dependencies if you are new to ReviewBoard)
Thanks Anand. I have made the python binding changes locally on my machine. Do you want me to create a new JIRA bug for this issue and create a new review or add the patch to this JIRA/review itself? I am little confused as to how the dependencies are handled with RB. - Vijay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/#review156423 ----------------------------------------------------------- On Nov. 21, 2016, 4:35 a.m., Vijay Srinivasaraghavan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53825/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2016, 4:35 a.m.) > > > Review request for mesos, Anand Mazumdar and Zameer Manji. > > > Bugs: MESOS-6597 > https://issues.apache.org/jira/browse/MESOS-6597 > > > Repository: mesos > > > Description > ------- > > MESOS-6597 Enabled java protos generation for all V1 proto files. > > > Diffs > ----- > > include/mesos/v1/allocator/allocator.proto > 73d45b37a7afc47366a4a01a36912f30b47c30b1 > src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac > > Diff: https://reviews.apache.org/r/53825/diff/ > > > Testing > ------- > > > Thanks, > > Vijay Srinivasaraghavan > >
