----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/#review165630 -----------------------------------------------------------
src/checks/health_checker.hpp (line 183) <https://reviews.apache.org/r/55901/#comment237494> What is it in the case of Docker containerizer? I think it is worth mentioning. src/checks/health_checker.cpp (line 579) <https://reviews.apache.org/r/55901/#comment237611> is this deferred only because you want to access `taskId`? why not just pass taskId to the lambda directly and not-defer? src/checks/health_checker.cpp (line 582) <https://reviews.apache.org/r/55901/#comment237610> s/of a command/of command/ src/checks/health_checker.cpp (line 608) <https://reviews.apache.org/r/55901/#comment237616> s/not returned/timed out/ src/checks/health_checker.cpp (line 617) <https://reviews.apache.org/r/55901/#comment237612> do you want to add a TODO here to not re-use the ContainerID? src/checks/health_checker.cpp (line 619) <https://reviews.apache.org/r/55901/#comment237625> why does this wait has repair but not the one in `__nestedCommandHealthCheck` ? src/checks/health_checker.cpp (line 620) <https://reviews.apache.org/r/55901/#comment237613> s/WaitForNestedContainer/WaitNestedContainer/ src/checks/health_checker.cpp (lines 620 - 621) <https://reviews.apache.org/r/55901/#comment237614> s/no matter if/irrespective of whether/ src/checks/health_checker.cpp (line 625) <https://reviews.apache.org/r/55901/#comment237615> s/WaitFor/Wait/ src/checks/health_checker.cpp (line 627) <https://reviews.apache.org/r/55901/#comment237624> won't we be losing the info about why wait failed? src/tests/health_check_tests.cpp (line 2122) <https://reviews.apache.org/r/55901/#comment237626> s/is/in/ - Vinod Kone On Feb. 10, 2017, 6:40 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55901/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2017, 6:40 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > ------- > > Added support for command health checks to the default executor. > > > Diffs > ----- > > src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5 > src/checks/health_checker.cpp a5225ff1f4b071ed4182d41fa8ecc705fa4dbe00 > src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a > src/tests/health_check_tests.cpp 7b6a803a28b2e4f6c27e9a0c4f668350ec2d5a81 > > Diff: https://reviews.apache.org/r/55901/diff/ > > > Testing > ------- > > Introduced a new test: `HealthCheckTest.DefaultExecutorCmdHealthCheck`. It > passes on Linux, but not on macOS, because of MESOS-7050. > > > Thanks, > > Gastón Kleiman > >
