> On Feb. 15, 2017, 9:40 p.m., Vinod Kone wrote: > > src/checks/health_checker.cpp, line 664 > > <https://reviews.apache.org/r/55901/diff/1-10/?file=1613998#file1613998line664> > > > > won't we be losing the info about why wait failed?
Yes, but the health check timed out anyway, we call `WaitNestedContainer`, only to ensure that the next `LaunchNestedContainerSession` call won't fail, so I don't think that a user would care about the details of the `WaitNestedContainer` call. We could log the response `VLOG(1)` or `VLOG(2)`, to make it easier to debug potential Mesos bugs. In our offline discussions we also realized that reusing the `ContainerID` is not always safe, so we'll have to replace this wait call with a wait + cleanupContainer. > On Feb. 15, 2017, 9:40 p.m., Vinod Kone wrote: > > src/checks/health_checker.cpp, line 616 > > <https://reviews.apache.org/r/55901/diff/1-10/?file=1613998#file1613998line616> > > > > is this deferred only because you want to access `taskId`? why not just > > pass taskId to the lambda directly and not-defer? Because the compiler complains about not being able to capture a non-variable: ``` ../../src/checks/health_checker.cpp:584:26: error: capture of non-variable ‘mesos::internal::checks::HealthCheckerProcess::taskId’ ``` > On Feb. 15, 2017, 9:40 p.m., Vinod Kone wrote: > > src/checks/health_checker.cpp, line 654 > > <https://reviews.apache.org/r/55901/diff/1-10/?file=1613998#file1613998line654> > > > > do you want to add a TODO here to not re-use the ContainerID? I don't know if we should commit this with that TODO, or if I should wait until MESOS-7120 is resolved, and then update this patch to not re-use the ContainerID. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/#review165630 ----------------------------------------------------------- On Feb. 10, 2017, 6:40 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55901/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2017, 6:40 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > ------- > > Added support for command health checks to the default executor. > > > Diffs > ----- > > src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5 > src/checks/health_checker.cpp a5225ff1f4b071ed4182d41fa8ecc705fa4dbe00 > src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a > src/tests/health_check_tests.cpp 7b6a803a28b2e4f6c27e9a0c4f668350ec2d5a81 > > Diff: https://reviews.apache.org/r/55901/diff/ > > > Testing > ------- > > Introduced a new test: `HealthCheckTest.DefaultExecutorCmdHealthCheck`. It > passes on Linux, but not on macOS, because of MESOS-7050. > > > Thanks, > > Gastón Kleiman > >
