> On Feb. 15, 2017, 9:40 p.m., Vinod Kone wrote: > > src/checks/health_checker.cpp > > Lines 617 (patched) > > <https://reviews.apache.org/r/55901/diff/1-10/?file=1613998#file1613998line654> > > > > do you want to add a TODO here to not re-use the ContainerID? > > Gastón Kleiman wrote: > I don't know if we should commit this with that TODO, or if I should wait > until MESOS-7120 is resolved, and then update this patch to not re-use the > ContainerID.
Added a TODO and addressed it in https://reviews.apache.org/r/57647/. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/#review165630 ----------------------------------------------------------- On March 6, 2017, 4:23 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55901/ > ----------------------------------------------------------- > > (Updated March 6, 2017, 4:23 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > ------- > > Added support for command health checks to the default executor. > > > Diffs > ----- > > src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5 > src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1 > src/launcher/default_executor.cpp 0ed436faa68e984d0be4e5186138f738bc7f1b52 > src/tests/health_check_tests.cpp 56e90747f2c943daee675738428d8ddeeafde36d > > > Diff: https://reviews.apache.org/r/55901/diff/13/ > > > Testing > ------- > > Introduced a new test: `HealthCheckTest.DefaultExecutorCmdHealthCheck`. It > passes on Linux, but not on macOS, because of MESOS-7050. > > > Thanks, > > Gastón Kleiman > >
