----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/#review169120 -----------------------------------------------------------
Fix it, then Ship it! src/checks/health_checker.cpp Lines 505-506 (patched) <https://reviews.apache.org/r/55901/#comment241442> We changed the `Accept` type for streaming responses recently (though the old type is still accepted for backwards compat) ``` Accept : stringify(ContentType::RECORDIO); Message-Accept: stringify(ContentType::ContentType::PROTOBUF) ``` - Vinod Kone On March 15, 2017, 3:05 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55901/ > ----------------------------------------------------------- > > (Updated March 15, 2017, 3:05 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > ------- > > See the summary. > > > Diffs > ----- > > src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5 > src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1 > src/launcher/default_executor.cpp 0ed436faa68e984d0be4e5186138f738bc7f1b52 > src/tests/health_check_tests.cpp fc1c8281ff8fbb76b7ac510ce36c98db4de4d171 > > > Diff: https://reviews.apache.org/r/55901/diff/14/ > > > Testing > ------- > > Introduced a new test: `HealthCheckTest.DefaultExecutorCmdHealthCheck`. It > passes on Linux, but not on macOS, because of MESOS-7050. > > > Thanks, > > Gastón Kleiman > >
