> On July 18, 2017, 7:27 a.m., Qian Zhang wrote: > > src/linux/cgroups.hpp > > Lines 575 (patched) > > <https://reviews.apache.org/r/60933/diff/1/?file=1778067#file1778067line575> > > > > Do you want to put all the methods above into a namespace (e.g., > > `namespace CFQ`)? That seems more aligned with the protobuf messages that > > you introduced in the previous patch. > > > > Or you could delete `message CFQ {` from the previous patch, that seems > > more consistent with the structure of blkio cgroup (blkio.xxx and > > blkio.throttle.xxxx)
Thought about that. Would prefer a corresponding `cfq` namespace. > On July 18, 2017, 7:27 a.m., Qian Zhang wrote: > > src/linux/cgroups.cpp > > Lines 1944 (patched) > > <https://reviews.apache.org/r/60933/diff/1/?file=1778068#file1778068line1944> > > > > Should we replace `unsigned int` with `dev_t` like the code below? > > https://github.com/apache/mesos/blob/1.3.0/src/linux/cgroups.cpp#L2572 > > > > Or actually I think the above code seems wrong, we should change it > > from `dev_t` to `unsigned int`. yea, should be `unsigned int` here for major or minor. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60933/#review180796 ----------------------------------------------------------- On July 18, 2017, 2:39 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60933/ > ----------------------------------------------------------- > > (Updated July 18, 2017, 2:39 p.m.) > > > Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and > Zhitao Li. > > > Bugs: MESOS-6162 > https://issues.apache.org/jira/browse/MESOS-6162 > > > Repository: mesos > > > Description > ------- > > - Data structure for Blkio entities > - Stats helpers for blkio.throttle.io* (generic blkio stats) > - Stats helpers for blkio.io* (CFQ related stats) > - Comments from the kernel blkio doc for helper functions > > > Diffs > ----- > > src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433 > src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5 > > > Diff: https://reviews.apache.org/r/60933/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
