----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review196986 -----------------------------------------------------------
src/checks/checks_runtime.hpp Lines 48 (patched) <https://reviews.apache.org/r/65394/#comment277027> I feel that copy is better than composition here. Who knows how these runtimes evolve, let's use `namespaces` and `taskPid` directly. src/checks/checks_runtime.hpp Lines 55-57 (patched) <https://reviews.apache.org/r/65394/#comment277028> This is not quite true: you only mean command health checks. HTTP and TCP are still performed by the executor directly. - Alexander Rukletsov On Jan. 30, 2018, 10:05 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65394/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2018, 10:05 a.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and > Gaston Kleiman. > > > Bugs: MESOS-8498 > https://issues.apache.org/jira/browse/MESOS-8498 > > > Repository: mesos > > > Description > ------- > > This patch is in preparation of another patch that will refactor the > health check code using these types. > > > Diffs > ----- > > src/checks/checks_runtime.hpp PRE-CREATION > src/checks/checks_types.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/65394/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Akash Gupta > >
