> On Feb. 7, 2018, 1:18 p.m., Alexander Rukletsov wrote: > > src/checks/checks_runtime.hpp > > Lines 55-57 (patched) > > <https://reviews.apache.org/r/65394/diff/2/?file=1950435#file1950435line55> > > > > This is not quite true: you only mean command health checks. HTTP and > > TCP are still performed by the executor directly.
Yeah that's true. I'll fix up the comment. - Akash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review196986 ----------------------------------------------------------- On Feb. 8, 2018, 7:44 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65394/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2018, 7:44 p.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and > Gaston Kleiman. > > > Bugs: MESOS-8498 > https://issues.apache.org/jira/browse/MESOS-8498 > > > Repository: mesos > > > Description > ------- > > This patch is in preparation of another patch that will refactor the > health check code using these types. > > > Diffs > ----- > > src/checks/checks_runtime.hpp PRE-CREATION > src/checks/checks_types.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/65394/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Akash Gupta > >
