----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review197925 -----------------------------------------------------------
src/checks/checks_types.hpp Lines 57-58 (patched) <https://reviews.apache.org/r/65394/#comment278163> Thinking more about it and looking at https://reviews.apache.org/r/65395, it is probably better to keep domain contruction in the appropriate checks. Adding `[]` is curl-specific (as said by the comment that will vanish after your changes), so embedding this peculiarity into `Http` check type description does not feel right. I'd go for just keeping `ipv6` flag here and keep the old code for domain construction in "checker_process.cpp". However I leave the decision to you. - Alexander Rukletsov On Feb. 16, 2018, 11:25 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65394/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2018, 11:25 p.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and > Gaston Kleiman. > > > Bugs: MESOS-8498 > https://issues.apache.org/jira/browse/MESOS-8498 > > > Repository: mesos > > > Description > ------- > > This patch is in preparation of another patch that will refactor the > health check code using these types. > > > Diffs > ----- > > src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 > src/checks/checks_runtime.hpp PRE-CREATION > src/checks/checks_types.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/65394/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Akash Gupta > >