----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review197348 -----------------------------------------------------------
src/checks/checks_runtime.hpp Lines 1-15 (patched) <https://reviews.apache.org/r/65394/#comment277477> Both these files probably need to be added to Autotools... when was the last time you tried a `../configure && make check`? I'd expect it to break with new headers. - Andrew Schwartzmeyer On Feb. 12, 2018, 2:50 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65394/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2018, 2:50 p.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and > Gaston Kleiman. > > > Bugs: MESOS-8498 > https://issues.apache.org/jira/browse/MESOS-8498 > > > Repository: mesos > > > Description > ------- > > This patch is in preparation of another patch that will refactor the > health check code using these types. > > > Diffs > ----- > > src/checks/checks_runtime.hpp PRE-CREATION > src/checks/checks_types.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/65394/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Akash Gupta > >