> On March 19, 2020, 10:47 a.m., Qian Zhang wrote: > > src/master/validation.cpp > > Lines 1839-1845 (patched) > > <https://reviews.apache.org/r/72216/diff/5/?file=2214199#file2214199line1839> > > > > So we have this validation only for the tasks within a task group but > > not for the tasks launched by `LAUNCH` operation? That means for the task > > whose `share_cgroups` is true, if it is launched by `LAUNCH_GROUP` then it > > is not allowed to specify resource limits, but if it is launched by > > `LAUNCH` then it is allowed to specify resource limits, this may confuse > > users, do we want to make them consistent? Like always allow to specify > > resource limits for any tasks. If we do this, then I think we may need to > > update the comments of the `TaskInfo.limits` and `Task.limits` protobuf > > message fields, since that field may have different meaning depending on > > the value of `share_cgroups`, like if `share_cgroups==false`, it is the > > limits of the task itself, otherwise the task may share limits with other > > tasks launched by the same executor.
I think we talked a lot during the design stage about why it doesn't make sense for resource limits to be set on task groups with share_cgroups==true. In hindsight, I wish we could have restricted this API to work only for task groups, but maybe that's not feasible. I would definitely prefer to still not allow task groups to set limits when share_cgroups==true. For most users (i.e. users who don't use custom executors), launching task groups is the only time that they will send multiple tasks/task groups to a single executor, so I think that's the case we really care about. I can update the comments accordingly. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72216/#review219999 ----------------------------------------------------------- On March 19, 2020, 2:10 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72216/ > ----------------------------------------------------------- > > (Updated March 19, 2020, 2:10 a.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10045 > https://issues.apache.org/jira/browse/MESOS-10045 > > > Repository: mesos > > > Description > ------- > > Added master validation for task resource limits and shared cgroups. > > > Diffs > ----- > > src/master/validation.cpp 084f281eadd65cb8ae0a19b7b7797dc71ccebdd2 > > > Diff: https://reviews.apache.org/r/72216/diff/5/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
