> On March 19, 2020, 10:47 a.m., Qian Zhang wrote: > > src/master/validation.cpp > > Lines 2072 (patched) > > <https://reviews.apache.org/r/72216/diff/5/?file=2214199#file2214199line2072> > > > > Is it possible that `shareCgroups.isSome()` is false at this point? I > > think as long as the task cgroup is not empty (at least contains one task), > > `shareCgroups.isSome()` must be true, right? So maybe we should do > > `CHECK_SOME(shareCgroups)`?
I think that for a custom executor, LAUNCH_GROUP with no tasks may be a valid use case? - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72216/#review219999 ----------------------------------------------------------- On March 19, 2020, 1:14 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72216/ > ----------------------------------------------------------- > > (Updated March 19, 2020, 1:14 p.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10045 > https://issues.apache.org/jira/browse/MESOS-10045 > > > Repository: mesos > > > Description > ------- > > Added master validation for task resource limits and shared cgroups. > > > Diffs > ----- > > src/master/validation.cpp 084f281eadd65cb8ae0a19b7b7797dc71ccebdd2 > > > Diff: https://reviews.apache.org/r/72216/diff/6/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
