cloud-fan commented on code in PR #36968:
URL: https://github.com/apache/spark/pull/36968#discussion_r905774631
##########
sql/core/src/test/scala/org/apache/spark/sql/internal/CatalogSuite.scala:
##########
@@ -743,4 +743,25 @@ class CatalogSuite extends SharedSparkSession with
AnalysisTest with BeforeAndAf
val catalogName2 = "catalog_not_exists"
assert(!spark.catalog.databaseExists(Array(catalogName2,
dbName).mkString(".")))
}
+
+ test("three layer namespace compatibility - get database") {
+ Seq(("testcat", "somedb"), ("testcat", "ns.somedb")).foreach { case
(catalog, dbName) =>
+ val qualifiedDb = s"$catalog.$dbName"
+ // TODO test properties? WITH DBPROPERTIES (prop='val')
Review Comment:
Shall we remove this TODO? it seems to be done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
