schuermannator commented on code in PR #36968:
URL: https://github.com/apache/spark/pull/36968#discussion_r907780722
##########
sql/core/src/test/scala/org/apache/spark/sql/internal/CatalogSuite.scala:
##########
@@ -749,4 +756,39 @@ class CatalogSuite extends SharedSparkSession with
AnalysisTest with BeforeAndAf
assert(spark.catalog.currentCatalog().equals("spark_catalog"))
assert(spark.catalog.listCatalogs().collect().map(c => c.name).toSet ==
Set("testcat"))
}
+
+ test("three layer namespace compatibility - get database") {
+ val catalogsAndDatabases =
+ Seq(("testcat", "somedb"), ("testcat", "ns.somedb"), ("spark_catalog",
"somedb"))
+ catalogsAndDatabases.foreach { case (catalog, dbName) =>
+ val qualifiedDb = s"$catalog.$dbName"
+ sql(s"CREATE NAMESPACE $qualifiedDb COMMENT 'test comment' LOCATION
'/test/location'")
+ val db = spark.catalog.getDatabase(qualifiedDb)
+ assert(db.name === dbName)
+ assert(db.description === "test comment")
+ assert(db.locationUri === "file:/test/location")
+ }
+ intercept[AnalysisException](spark.catalog.getDatabase("randomcat.db10"))
+ }
+
+ test("three layer namespace compatibility - get database, same in hive and
testcat") {
+ // create 'testdb' in hive and testcat
+ val dbName = "testdb"
+ sql(s"CREATE NAMESPACE spark_catalog.$dbName COMMENT 'hive database'")
+ sql(s"CREATE NAMESPACE testcat.$dbName COMMENT 'testcat namespace'")
+ sql("SET CATALOG testcat")
+ // should still return the database in Hive
+ val db = spark.catalog.getDatabase(dbName)
+ assert(db.name === dbName)
+ assert(db.description === "hive database")
+ // TODO catalog check API?
Review Comment:
removing comment then!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
