cloud-fan commented on code in PR #36968:
URL: https://github.com/apache/spark/pull/36968#discussion_r905777243
##########
sql/core/src/test/scala/org/apache/spark/sql/internal/CatalogSuite.scala:
##########
@@ -743,4 +743,25 @@ class CatalogSuite extends SharedSparkSession with
AnalysisTest with BeforeAndAf
val catalogName2 = "catalog_not_exists"
assert(!spark.catalog.databaseExists(Array(catalogName2,
dbName).mkString(".")))
}
+
+ test("three layer namespace compatibility - get database") {
+ Seq(("testcat", "somedb"), ("testcat", "ns.somedb")).foreach { case
(catalog, dbName) =>
+ val qualifiedDb = s"$catalog.$dbName"
+ // TODO test properties? WITH DBPROPERTIES (prop='val')
+ sql(s"CREATE NAMESPACE $qualifiedDb COMMENT 'test comment' LOCATION
'/test/location'")
+ val db = spark.catalog.getDatabase(qualifiedDb)
+ assert(db.name === dbName)
+ assert(db.description === "test comment")
+ assert(db.locationUri === "file:/test/location")
+ }
+ intercept[AnalysisException](spark.catalog.getDatabase("randomcat.db10"))
+ }
+
+ test("get database when there is `default` catalog") {
+ spark.conf.set("spark.sql.catalog.default",
classOf[InMemoryCatalog].getName)
+ val db = "testdb"
+ val qualified = s"default.$db"
+ sql(s"CREATE NAMESPACE $qualified")
Review Comment:
I think what we should test is: there is a database called `testdb` in Hive
Metastore, and also a namespace called `testdb` in `testcat`. The current
catalog is `testcat` (we can change it via `sql("SET CATALOG testcat")`), and
`getDatabase` should return the database in Hive Metastore. We can check the
catalog by `Database.catalog`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
