jiangzho commented on PR #268: URL: https://github.com/apache/spark-kubernetes-operator/pull/268#issuecomment-3046772279
The e2e tests have been fixed - underlying reason is my lack of updating the staged CRD yaml file for the new field. I'm thinking of some future options (that can be dealt with separately from this JIRA) * Add a developer guide doc reminding that the staged YAML needs to be updated manually, and/or * Have another PRB that fails when inconsistency is detected between the staged vs. the generated yaml, and/or * Stage the old (v1alpha1/v1beta1) versions only, then merge them with the latests generated version (v1) & move the merged version to helm chart For now, updating the yaml file can unblock tests for this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
