dongjoon-hyun commented on code in PR #268: URL: https://github.com/apache/spark-kubernetes-operator/pull/268#discussion_r2191398058
########## docs/spark_custom_resources.md: ########## @@ -289,12 +289,18 @@ On the other hand, when developing an application, it's possible to configure ```yaml applicationTolerations: # Acceptable values are 'Always', 'OnFailure', 'Never' - resourceRetentionPolicy: OnFailure + # Setting this to 'OnFailure' would retain secondary resources if and only if the app fails + resourceRetainPolicy: OnFailure Review Comment: Please spin off this documentation typo, `resourceRetentionPolicy` -> `resourceRetainPolicy` because it is orthogonal to `resourceRetainDurationMillis`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
