jiangzho commented on code in PR #268:
URL: 
https://github.com/apache/spark-kubernetes-operator/pull/268#discussion_r2193553275


##########
build-tools/helm/spark-kubernetes-operator/crds/sparkapplications.spark.apache.org-v1.yaml:
##########
@@ -17411,6 +17411,8 @@ spec:
                         minExecutors:
                           type: integer
                       type: object
+                    resourceRetainDurationMillis:
+                      type: integer

Review Comment:
   The first commit introduces the feature to v1 only and usee would need to 
upgrade to v1.
   
   I do agree that technically our operator still supports all versions and 
this can be introduced to all versions. I'll upgrade all them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to