dongjoon-hyun commented on code in PR #268: URL: https://github.com/apache/spark-kubernetes-operator/pull/268#discussion_r2191398469
########## docs/spark_custom_resources.md: ########## @@ -289,12 +289,18 @@ On the other hand, when developing an application, it's possible to configure ```yaml applicationTolerations: # Acceptable values are 'Always', 'OnFailure', 'Never' - resourceRetentionPolicy: OnFailure + # Setting this to 'OnFailure' would retain secondary resources if and only if the app fails + resourceRetainPolicy: OnFailure + # Secondary resources would be garbage collected 10 minutes after app termination + resourceRetainDurationMillis: 600000 + ``` to avoid operator attempt to delete driver pod and driver resources if app fails. Similarly, -if resourceRetentionPolicy is set to `Always`, operator would not delete driver resources -when app ends. Note that this applies only to operator-created resources (driver pod, SparkConf +if resourceRetainPolicy is set to `Always`, operator would not delete driver resources Review Comment: ditto. Please handle this typo-fix PR independently, `resourceRetentionPolicy` -> `resourceRetainPolicy` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
