anshulbaliga7 commented on PR #58077: URL: https://github.com/apache/spark/pull/58077#issuecomment-5505135700
Thanks for the review @cloud-fan , have addressed all three: - Corrected the empty-set comment to accurately describe both branches (current behavior skips `child.eval` entirely and legacy behavior still evaluates it and can return NULL) - Fixed the nondeterministic-test rationale: filter-IN is unreachable via `RewritePredicateSubquery`'s rewrite to LeftSemi (not `CheckAnalysis`), and a pre-initialize() eval throws `IllegalArgumentException` (not `IllegalStateException`) - Replaced the `partitionInitializationStatements` string check with an actual compile-and-execute test via `GeneratePredicate.generate`, confirmed with a negative control and removing the registration loop makes the test fail with exactly that `IllegalArgumentException` 8/8 tests pass. Can you PTALa again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
