anshulbaliga7 commented on PR #58077: URL: https://github.com/apache/spark/pull/58077#issuecomment-5521527103
Thanks for the review @cloud-fan , have addressed all four: - Extended the nullable-LHS/non-nullable-RHS test with Case B: a fully non-null RHS (99, 2) against nullable `LHS (NULL, 1)`, asserting NOT IN is TRUE via the second field's definitive mismatch which exercises the `nonNullSet` scan specifically, distinct from the nullRows loop the existing case covered - Added an end-to-end SQL regression `(SELECT (id, rand(42) >= 0.0) IN (...) FROM lhs)` proving the nondeterministic codegen fallback is reachable via a Project, and corrected the prior test's comment such that it's not unreachable via SQL, just that the direct-construction test is a more targeted check of the registration logic - Removed the unnecessary `withSQLConf` override on the primary nullability test and fixed the comment: 5 NOT IN (...) is a constant referencing neither join input, so `RewritePredicateSubquery` leaves the Join unchanged regardless of the optimizer conf - Reordered the null-check in the candidate scan to test `inputField == null` before calling `candidate.get(...)`, avoiding an unnecessary row access when the LHS field alone already determines UNKNOWN 11/11 tests pass. Can you PTAL again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
