anshulbaliga7 commented on PR #58077:
URL: https://github.com/apache/spark/pull/58077#issuecomment-5515124425
Thanks for the review @cloud-fan , have addressed all six:
- Forced the primary nullability regression through `InSubqueryExec` by
disabling the join-condition rewrite and added an assertion on the executed
plan (via `Expression.exists` recursing into the expression tree) confirming
`InSubqueryExec` is actually present before checking results
- Added a legacy empty-RHS regression: forces the physical path with ANSI +
`LEGACY_NULL_IN_EMPTY_LIST_BEHAVIOR=true`, and asserts a `DIVIDE_BY_ZERO` LHS
actually throws proving the legacy branch evaluates the LHS rather than
short-circuiting
- Added a null-vs-null regression distinguishing (NULL,1) IN ((NULL,1))
(UNKNOWN) from (NULL,1) IN ((NULL,2)) (FALSE via a later definitive mismatch)
- Fixed the `multiColNullRows` comment to accurately describe it as an Array
(deduplicated via a temporary TreeSet at construction), not a TreeSet
- Fixed the subject-verb agreement nit ("columns force")
- Renamed the multi-column legacy test to complete the sentence
10/10 tests pass. Can you PTAL again? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
