urosstan-db commented on code in PR #58621:
URL: https://github.com/apache/spark/pull/58621#discussion_r3958336633


##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala:
##########
@@ -382,6 +384,28 @@ class PostgresIntegrationSuite extends 
SharedJDBCIntegrationSuite {
     assert(sql("select c1, c3 from queryOption").collect().toSet == 
expectedResult)
   }
 
+  test("SPARK-57780: do not classify insufficient privilege as a syntax 
error") {
+    val restrictedUser = "restricted_user"
+    val restrictedPassword = "restricted_password"
+    val restrictedJdbcUrl = 
s"jdbc:postgresql://$dockerIp:$externalPort/postgres"
+
+    Using.resource(getConnection()) { conn =>
+      conn.prepareStatement(s"CREATE USER $restrictedUser PASSWORD 
'$restrictedPassword'")
+        .executeUpdate()
+    }
+
+    val postgresError = intercept[SQLException] {
+      spark.read.format("jdbc")
+        .option("url", restrictedJdbcUrl)
+        .option("dbtable", "bar")
+        .option("user", restrictedUser)
+        .option("password", restrictedPassword)
+        .load()
+    }
+    assertResult("42501")(postgresError.getSQLState)
+    assertResult("ERROR: permission denied for table 
bar")(postgresError.getMessage)

Review Comment:
   We miss finally with stack preserving to dropUser.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to