urosstan-db commented on code in PR #58621: URL: https://github.com/apache/spark/pull/58621#discussion_r3969619523
########## sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala: ########## @@ -260,7 +260,10 @@ private case class PostgresDialect() // See https://www.postgresql.org/docs/current/errcodes-appendix.html override def isSyntaxErrorBestEffort(exception: SQLException): Boolean = { - Option(exception.getSQLState).exists(_.startsWith("42")) Review Comment: Totally agreed, I planned to make a folow-up with additional tests (e.g. querying non existing table should not be clasified as syntax error). And in that additional testing, we may catch issues on other dialects. https://issues.apache.org/jira/browse/SPARK-59369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
