urosstan-db commented on code in PR #58621:
URL: https://github.com/apache/spark/pull/58621#discussion_r3969684174
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala:
##########
@@ -382,6 +385,34 @@ class PostgresIntegrationSuite extends
SharedJDBCIntegrationSuite {
assert(sql("select c1, c3 from queryOption").collect().toSet ==
expectedResult)
}
+ test("SPARK-59336: do not classify insufficient privilege as a syntax
error") {
+ val restrictedUser = "restricted_user"
+ val restrictedPassword = "restricted_password"
+ val restrictedJdbcUrl =
s"jdbc:postgresql://$dockerIp:$externalPort/postgres"
+
+ Using.resource(getConnection()) { conn =>
+ conn.prepareStatement(s"CREATE USER $restrictedUser PASSWORD
'$restrictedPassword'")
+ .executeUpdate()
+ }
+
+ Utils.tryWithSafeFinally {
+ val postgresError = intercept[SQLException] {
+ spark.read.format("jdbc")
+ .option("url", restrictedJdbcUrl)
+ .option("dbtable", "bar")
+ .option("user", restrictedUser)
+ .option("password", restrictedPassword)
+ .load()
+ }
+ assertResult("42501")(postgresError.getSQLState)
+ assertResult("ERROR: permission denied for table
bar")(postgresError.getMessage)
Review Comment:
Good proposal, I will make error less restrictive and use IF EXISTS syntax
(it is supported from pg server 8.2, released in 20 years ago), so even if
someone provide older docker image version for testing, syntax would work.
I also, used some special spark's Util method (I forgot the exact name) to
preserve stack trace if finally fails
(https://github.com/apache/spark/pull/58621#discussion_r3958336633).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
