uros-b commented on PR #58621:
URL: https://github.com/apache/spark/pull/58621#issuecomment-5601660159
Also, please consider updating the user-facing section of the PR
description. The impact is a bit broader than the description currently says.
The write-up reads as “don’t treat 42501 as syntax.” The allowlist also
stops wrapping other class-42 states (42P01 undefined table, 42703 undefined
column, grouping/type errors, …).
That is the intended contract, and it matters on a real path:
JDBCRDD.resolveTable only consults isObjectNotFoundException when ident is
defined. A normal spark.read.format("jdbc").option("dbtable", …) probe of a
missing table currently becomes JDBC_EXTERNAL_ENGINE_SYNTAX_ERROR because 42P01
starts with 42. After this PR it surfaces as a SQLException.
Please state that explicitly under “user-facing change,” including that the
error type/class changes for those cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
