Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-162503043
@ygcao can we remove the code changes related to the `cosineSimilarity` and
`findSynonyms`? This will make it cleaner so we can focus on the core issue
(see my next comment).
Also, I think that things like distance metrics should live in a
centralized place, and so changes to these are outside the scope of this
particular model and the PR. In fact, the original `cosineSimilarity` method
(https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala#L472)
is no longer used, as it's been replaced by a more efficient version, so we
should consider deprecating it (or indeed just removing it as it's private and
always has been).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
