Github user ygcao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r46923499
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -534,8 +588,13 @@ class Word2VecModel private[spark] (
// Need not divide with the norm of the given vector since it is
constant.
val cosVec = cosineVec.map(_.toDouble)
var ind = 0
+ var vecNorm = 1f
+ if (norm)
+ vecNorm = blas.snrm2(vectorSize, fVector, 1)
--- End diff --
Glad to see another pull request demanded the same normalization. I think
my change is more backward compatible and leave user choice of speed or
normalized metrics for further operations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
