Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-162750381
@MLnick
> So let's focus this PR in on making the max sentence size configurable,
if this is desirable?
+1
> It does seem a little strange to me thinking about it to discard sentence
boundaries.
How are they being discarded? Each row in the data given to MLlib is
treated as a separate sentence; i.e., we aren't trying to model similarity
across sentences (as far as I can tell glancing at it). If people want to work
with a unit other than sentences, then each unit can be on a separate row. Am
I misunderstanding?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
