Github user devaraj-kavali commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12031#discussion_r58342616
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -319,10 +319,14 @@ private[spark] class Executor(
     
             case _: TaskKilledException | _: InterruptedException if 
task.killed =>
               logInfo(s"Executor killed $taskName (TID $taskId)")
    +          // Reset the interrupted status of the thread to update the 
status
    +          Thread.interrupted()
               execBackend.statusUpdate(taskId, TaskState.KILLED, 
ser.serialize(TaskKilled))
    --- End diff --
    
    Thanks @zsxwing for looking into the patch.
    
    > What will happen if the thread is interrupted when 
execBackend.statusUpdate is running? I think the executor will still crash.
    
    
    I do think this is a problem. I have handled it in the latest, Can you look 
into the changes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to