Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60622524
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
---
@@ -149,16 +149,23 @@ public void registerExecutor(
ExecutorShuffleInfo executorInfo) {
AppExecId fullId = new AppExecId(appId, execId);
logger.info("Registered executor {} with {}", fullId, executorInfo);
- try {
- if (db != null) {
- byte[] key = dbAppExecKey(fullId);
- byte[] value =
mapper.writeValueAsString(executorInfo).getBytes(StandardCharsets.UTF_8);
- db.put(key, value);
+ if
("org.apache.spark.shuffle.sort.SortShuffleManager".equals(executorInfo.shuffleManager)
--- End diff --
I'd reorganize this a bit to avoid some repetition and indentation. e.g.:
```
List<String> knownManagers =
Arrays.asList("org.apache.spark.shuffle.sort.SortShuffleManager",
"org.apache.spark.shuffle.unsafe.UnsafeShuffleManager")
if (!knownManagers.contains(executorInfo.shuffleManager)) {
throw SomeException()
}
// Register executor.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
