Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60622768
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleCleanupSuite.java
---
@@ -37,19 +37,20 @@
// Same-thread Executor used to ensure cleanup happens synchronously in
test thread.
private Executor sameThreadExecutor = MoreExecutors.sameThreadExecutor();
private TransportConf conf = new TransportConf("shuffle", new
SystemPropertyConfigProvider());
+ static String SORT_MANAGER =
"org.apache.spark.shuffle.sort.SortShuffleManager";
--- End diff --
nit: private? final?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
