Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60623144
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java
---
@@ -186,7 +186,12 @@ public void testFetchThreeSort() throws Exception {
@Test
public void testFetchInvalidShuffle() throws Exception {
- registerExecutor("exec-1", dataContext0.createExecutorInfo("unknown
sort manager"));
+ try {
--- End diff --
Yeah, this would be better as a separate test:
```
@Test(expect=TheExpectedException.class)
public void testInvalidShuffleManager() {
registerExecutor("exec-1", dataContext0.createExecutorInfo("unknown sort
manager"));
}
```
(Not sure about the names of the arguments, but it's something like that.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
