Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r87904353
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/MinHashLSHSuite.scala ---
@@ -24,7 +24,7 @@ import org.apache.spark.ml.util.DefaultReadWriteTest
import org.apache.spark.mllib.util.MLlibTestSparkContext
import org.apache.spark.sql.Dataset
-class MinHashSuite extends SparkFunSuite with MLlibTestSparkContext with
DefaultReadWriteTest {
+class MinHashLSHSuite extends SparkFunSuite with MLlibTestSparkContext
with DefaultReadWriteTest {
--- End diff --
Looking at the code for LSH, I see a few requires on input to some of the
public methods, but there aren't tests for these edge cases. Specifically we
should add
**MinHash**
* tests for empty vectors (or all zero vectors)
* tests for `inputDim > prime / 2`
**LSH**
* Test for `numNearestNeighbors < 0`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
