Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r87875688
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -46,21 +42,23 @@ import org.apache.spark.sql.types.StructType
@Since("2.1.0")
class MinHashModel private[ml] (
--- End diff --
Not specifically related to this pr: I checked and the default random uids
used in ML library never contain spaces. For more complex uids, it seems more
common to use camel case, but I do see some with hyphens. Can we make the
default uids: `"mh-lsh"` and `"brp-lsh"` or similar?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
