Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15874#discussion_r87876322 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala --- @@ -102,8 +103,7 @@ class MinHashModel private[ml] ( */ @Experimental @Since("2.1.0") -class MinHash(override val uid: String) extends LSH[MinHashModel] with HasSeed { - +class MinHashLSH(override val uid: String) extends LSH[MinHashModel] with HasSeed { --- End diff -- change the model names to reflect the new estimator names.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org