Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r87878252
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -102,8 +103,7 @@ class MinHashModel private[ml] (
*/
@Experimental
@Since("2.1.0")
-class MinHash(override val uid: String) extends LSH[MinHashModel] with
HasSeed {
-
+class MinHashLSH(override val uid: String) extends LSH[MinHashModel] with
HasSeed {
--- End diff --
Also, the comment above says:
````
* ... For example,
* `Vectors.sparse(10, Array[(2, 1.0), (3, 1.0), (5, 1.0)])`
* means there are 10 elements in the space. This set contains elem 2, elem
3 and elem 5.
* Also, any input vector must have at least 1 non-zero indices, and all
non-zero values are treated
* as binary "1" values.
````
Can we change it to:
````
* ... For example,
* `Vectors.sparse(10, Array((2, 1.0), (3, 1.0), (5, 1.0)))`
* means there are 10 elements in the space. This set contains non-zero
values at indices 2, 3, and
* 5. Also, any input vector must have at least 1 non-zero index, and all
non-zero values are
* treated as binary "1" values.
````
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
