Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17758#discussion_r125489566 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -468,7 +489,13 @@ case class DataSource( throw new AnalysisException("Cannot save interval data type into external storage.") } - providingClass.newInstance() match { + val resolvedRelation = providingClass.newInstance() match { + case relationToCheck: DataSourceValidator => --- End diff -- ok this is a special case, let's leave the checking logic in `JDBCUtils`. But I think my proposal is still valid for external data source which can infer schema.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org