Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17758#discussion_r126074450
  
    --- Diff: sql/core/src/test/resources/sql-tests/inputs/create.sql ---
    @@ -0,0 +1,23 @@
    +-- Catch case-sensitive name duplication
    +SET spark.sql.caseSensitive=true;
    +
    +CREATE TABLE t(c0 STRING, c1 INT, c1 DOUBLE, c0 INT) USING parquet;
    --- End diff --
    
    We should keep them in one place. For now I think we still need to put them 
in `DDLSuite` because we need to run it with and without hive support. Can we 
pick some typical test cases here and move them to `DDLSuite`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to