Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17758#discussion_r125889801
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -422,6 +405,18 @@ case class DataSource(
s"$className is not a valid Spark SQL Data Source.")
}
+ (relation match {
+ case hs: HadoopFsRelation =>
+ Some((hs.dataSchema.map(_.name), hs.partitionSchema.map(_.name)))
+ case bs: BaseRelation =>
+ Some((bs.schema.map(_.name), Seq.empty[String]))
+ case _ =>
+ None
+ }).foreach { case (dataCols, partCols) =>
+ SchemaUtils.checkColumnNameDuplication(dataCols, "in the data
schema", equality)
+ SchemaUtils.checkColumnNameDuplication(partCols, "in the partition
column(s)", equality)
--- End diff --
can we just inline these 2 checks in the above 2 cases?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
