Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17758#discussion_r125564070
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -304,7 +329,13 @@ case class DataSource(
case (dataSource: SchemaRelationProvider, Some(schema)) =>
dataSource.createRelation(sparkSession.sqlContext,
caseInsensitiveOptions, schema)
case (dataSource: RelationProvider, None) =>
- dataSource.createRelation(sparkSession.sqlContext,
caseInsensitiveOptions)
+ val baseRelation =
+ dataSource.createRelation(sparkSession.sqlContext,
caseInsensitiveOptions)
+ SchemaUtils.checkColumnNameDuplication(
+ baseRelation.schema.map(_.name),
+ "in the relation schema",
+ equality)
+ baseRelation
--- End diff --
an idea to unify the validation for both user-specified schema and inferred
schema: we can put the validation at the end of `resolveRelation`:
```
relation match {
case h: HadoopFsRelation =>
// validate data schema
// validate partition schema
// validate bucket
case _ => // validate data schema
}
relation
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
