Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141643992
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -724,6 +724,7 @@ private[spark] class TaskSetManager(
logInfo(s"Killing attempt ${attemptInfo.attemptNumber} for task
${attemptInfo.id} " +
s"in stage ${taskSet.id} (TID ${attemptInfo.taskId}) on
${attemptInfo.host} " +
s"as the attempt ${info.attemptNumber} succeeded on ${info.host}")
+ attemptInfo.markKilledByOtherAttempt
--- End diff --
nit: this has a side-effect, so the normal scala-style is to call this w/
parens:
`attemptInfo.markKilledByOtherAttempt()`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
